Skip to content

Support "include" feature for the Yosys frontend in run vtr flow scripts #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 14, 2022

Conversation

sdamghan
Copy link
Member

@sdamghan sdamghan commented Jun 30, 2022

Description

This PR adds support for passing multiple input designs to the Yosys frontend of the VTR flow using run vtr flow scripts.
CI tests verifying this functionality for all VTR frontends are added correspondingly.

  • New feature:
    include files, written in supported HDLs by each fronted, are only passed to the frontend for synthesis. The rest will be only copied to the destination folder. This is helpful since users can include memory initialization files in the destination folder.

Related Issue

In accordance with PR #2068

Motivation and Context

Adding benchmarks with multiple design files become available for the Yosys frontend in VTR

How Has This Been Tested?

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@sdamghan sdamghan force-pushed the include_dir_scripts branch from 6c48931 to 32d455c Compare June 30, 2022 17:24
@github-actions github-actions bot added the infra Project Infrastructure label Jun 30, 2022
@sdamghan sdamghan changed the title Support "include" feature for the Yosys fronted in run vtr flow scripts Support "include" feature for the Yosys frontend in run vtr flow scripts Jun 30, 2022
@sdamghan sdamghan force-pushed the include_dir_scripts branch from 4a40ed9 to 1c28406 Compare July 4, 2022 14:49
@sdamghan
Copy link
Member Author

sdamghan commented Jul 5, 2022

@vaughnbetz - This PR is ready to merge, It would be great to know your thoughts. The CI failures are due to a change in the VTR_ROOT/.github/workflows/test.yml, which will be resolved once we merge it into the master branch (GitHub actions will be updated). I have compiled the VTR flow with the new configuration of the Test / S: Basic CI test, and the flow passed the vtr_reg_basic test successfully.

@sdamghan sdamghan force-pushed the include_dir_scripts branch 2 times, most recently from 8832749 to 3accbe7 Compare July 8, 2022 17:49
sdamghan added 4 commits July 8, 2022 15:32
	 - add tests to check the "include" feature works properly for all VTR frontends

Signed-off-by: Seyed Alireza Damghani <[email protected]>
	 build folder to have access to executables for using
	 in VTR scripts (similar to other tools in VTR)

Signed-off-by: Seyed Alireza Damghani <[email protected]>
@sdamghan sdamghan force-pushed the include_dir_scripts branch from 3accbe7 to 78bbbc0 Compare July 8, 2022 18:32
sdamghan added 2 commits July 11, 2022 15:11
…ctory

	 and ignoring them as the design benchmark set for synthesis

Signed-off-by: Seyed Alireza Damghani <[email protected]>
@sdamghan sdamghan force-pushed the include_dir_scripts branch from b44f92b to f7065ee Compare July 11, 2022 18:11
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor typo fixes and suggestions for comment modifications. I'll merge now, since none of this is gating, but please take a look and if you agree with the suggestions incorporate them in a future PR.

@vaughnbetz vaughnbetz merged commit e0525c5 into verilog-to-routing:master Jul 14, 2022
@sdamghan sdamghan mentioned this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external_libs infra Project Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants